Add loads method overloads to GenericSchema class

This commit is contained in:
Daniil Fajnberg 2023-03-10 18:01:20 +01:00
parent bff3c7ef52
commit 72218fd2cb
Signed by: daniil-berg
GPG Key ID: BE187C50903BEE97
2 changed files with 51 additions and 3 deletions

View File

@ -66,3 +66,44 @@ class GenericSchema(GenericInsightMixin[_T], Schema):
correctly based on the type argument passed to a specific subclass.
"""
...
@overload # type: ignore[override]
def loads(
self,
json_data: str,
*,
many: Literal[True],
partial: Union[bool, Sequence[str], set[str], None] = None,
unknown: Optional[str] = None,
**kwargs: Any,
) -> list[_T]:
...
@overload
def loads(
self,
json_data: str,
*,
many: Optional[Literal[False]] = None,
partial: Union[bool, Sequence[str], set[str], None] = None,
unknown: Optional[str] = None,
**kwargs: Any,
) -> _T:
...
def loads(
self,
json_data: str,
*,
many: Optional[bool] = None,
partial: Union[bool, Sequence[str], set[str], None] = None,
unknown: Optional[str] = None,
**kwargs: Any,
) -> Union[list[_T], _T]:
"""
Same as `marshmallow.Schema.loads` at runtime.
Annotations ensure that type checkers will infer the return type
correctly based on the type argument passed to a specific subclass.
"""
...

View File

@ -20,7 +20,7 @@ class GenericSchemaTestCase(TestCase):
mock__get_type_arg.assert_called_once_with()
mock_cls.assert_called_once_with(**mock_data)
def test_load(self) -> None:
def test_load_and_loads(self) -> None:
"""Mainly for static type checking purposes."""
class Foo:
@ -29,9 +29,16 @@ class GenericSchemaTestCase(TestCase):
class TestSchema(schema.GenericSchema[Foo]):
pass
single: Foo = TestSchema().load({})
single: Foo
single = TestSchema().load({})
self.assertIsInstance(single, Foo)
single = TestSchema().loads("{}")
self.assertIsInstance(single, Foo)
multiple: list[Foo] = TestSchema().load([{}], many=True)
multiple: list[Foo]
multiple = TestSchema().load([{}], many=True)
self.assertIsInstance(multiple, list)
self.assertIsInstance(multiple[0], Foo)
multiple = TestSchema().loads("[{}]", many=True)
self.assertIsInstance(multiple, list)
self.assertIsInstance(multiple[0], Foo)